JavaScript bug fix: "Schedule Friday" workflow

[t-will-gillis]

Overview

There is a bug in the "Schedule Friday" workflow that causes it to fail during runtime. We need to address this bug so that the workflow completes. Note: although this involves GitHub Actions / workflows, the main priority is to identify the bug in the JavaScript file and demonstrate a solution.

Details

Refer to the Schedule Friday workflow logs. Starting with the June 7th run, the workflow fails due to an error:

Observations which may or may not be relevant:

• This error appears to occur in find-linked-issue.js with the set of "Pre-work Checklists" beginning with issue 6882.
• On the May 31st run, the same issue was processed and did not cause an error.
• On the most recent run, the workflow processed more recent "Pre-work Checklists", but the error did not occur until it reached the batch of preworks beginning with 6882.
• There was a recent PR #6550 that edited these files and might be related; however, the successful May 31st run happened after this PR was merged.
• We migrated to the Projects Beta last week, and the PR #7055 also made edits to this workflow; however, the same error seems to be occurring with the same set of preworks.

Action Items

• [x] Review the workflow logs and the pertinent files and test what the problem might be
• [x] If you find the error, please propose a fix
• [x] Either way, present your findings to the Team

Resources/Instructions

• schedule-fri-0700
• add-labels.js
• find-linked-issues.js

[github-actions[bot]]

Hi @t-will-gillis, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

[t-will-gillis]

While reviewing the recommendations in #6840 (thank you, @joey-ma) , I re-reviewed the error that keeps stopping the "Schedule Friday" workflow at the same point (i.e. when reviewing issue 6882). I was unable to determine why the error repeatedly occurred at this specific issue: for some reason, the body of this specific "Pre-work Checklist" resolves to a 'null' value, and running matchAll() on a null value raises a TypeError. Note: this error does not occur with the set of pre-work issues before this one, nor with the set after. Since the return value from running findLinkedIssue() on a "Pre-work Checklist" will be 'false' or 'null' or 'falsy' (there are no linked issues), it is safe to wrap let matches = text.matchAll(re) in a try-catch, log the TypeError at 6882, and let the function run to completion.