search

hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
324 stars 766 forks source link

ER: Fix mail links in "Privacy Policy" #7108

Closed t-will-gillis closed 1 month ago

t-will-gillis commented 3 months ago

Emergent Requirement - Problem

The mail links on the "Privacy Policy"[^1] page are broken, and send users to a "something went wrong" page. We need to fix three links on this page so that we receive emails from visitors.

Result of clicking on mail link Screenshot 2024-07-14 133152

Issue you discovered this emergent requirement in

Date discovered

7/14/24

Did you have to do something temporarily

Who was involved

@t-will-gillis, @ anitahammer (outside HfLA)

What happens if this is not addressed

The page is asking for the reader to send an email to notify us of potential problems, but the link does not work. We might not be receiving emails from readers of this page.

Recommended Action Items

Potential solutions [draft]

In the privacy-policy.yml^2 document, there are three locations (around lines 70, 80, and 92) where we indicate that users can contact us by email.

Resources

[^1]: Privacy Policy

HackforLABot commented 2 months ago

Hi @dcotelessa, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

dcotelessa commented 1 month ago

Availability: Sun 11:00-3pm, Tue-Wed: 3-5 ETA: 2 hours

dcotelessa commented 1 month ago

Issue Created:

https://github.com/hackforla/website/issues/7410 https://github.com/hackforla/website/issues/7411 https://github.com/hackforla/website/issues/7412

t-will-gillis commented 1 month ago

Hey @dcotelessa! Woohoo thanks for working on these- they look good. Just a couple suggestions:

jphamtv commented 1 month ago

Hi @dcotelessa -

Additional suggestions:

Once you've made these and @t-will-gillis's edits:

  1. Remove 'Draft' label
  2. Add 'ready for merge team' label

The team will then re-review. Thanks!

--

@t-will-gillis - Since these are split into three separate issues in the same file, should we relabel them as 'good first issues'? Or consolidate them into one issue if we want to keep it as a small complexity issue? Thoughts?

dcotelessa commented 1 month ago

Hey @dcotelessa! Woohoo thanks for working on these- they look good. Just a couple suggestions:

  • I think the issue titles will read better if the "7108: " is removed for each Updated titles.
  • I like to give the link to the actual file, either in the body of the issue or in "Resources/Instructions", e.g. "- privacy-policy.yml" Just to make it easier for whoever works on it Added footnotes. Sounds good!
  • Could you capitalize "Docker" ? Updated
  • I like that you are emphasizing the location of the change and that the change applies only to the section noted
t-will-gillis commented 1 month ago

@dcotelessa looks good- thanks for making all of the changes. @jphamtv about these issues' complexities: I agree that split into three, this is more like good first issues and that as one issue it would be Complexity: Small.

Ugh- the (not great) counter argument is to leave these as Complexity: Small since we need more small issues.

dcotelessa commented 1 month ago

Let me know if we want to label as good first issues, but for now they are set to Complexity: Small and close this IM.

t-will-gillis commented 1 month ago

Hey @dcotelessa Thanks, the issues look great and are prioritized-

Closing this issue as successfully completed.