hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
316 stars 754 forks source link

Add automatic retries to "Schedule Daily" GHA #7120

Closed t-will-gillis closed 2 weeks ago

t-will-gillis commented 1 month ago

Overview

When reviewing the "Schedule Daily" workflow logs, it can be seen that many days the workflow fails with the error: RequestError [HttpError]: You have exceeded a secondary rate limit. Please wait a few minutes before you try again... We need to add code to automatically retry the workflow a set number of times if the workflow does not successfully complete.

Details

It appears that the RequestError occurs in the function getAllRepos() in the file get-project-data.js. The RequestError is due to a secondary rate limit and the message suggests to wait a few minutes before retrying. Therefore we will want to incorporate code that retries the workflow a total of three times: at 2 minutes past the original failure, and if needed after 4 more minutes, and lastly if needed after 8 more minutes.

Action Items

*** There may be other appropriate ways to retry the failed workflows, for example: adding a retry step after "Generate github-data.json" in schedule-daily-1100.yml. FYI- Do not use a GitHub Marketplace action/automation.

Resources/Instructions

github-actions[bot] commented 1 month ago

Hi @t-will-gillis, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

HackforLABot commented 1 month ago

Hi @daras-cu, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

daras-cu commented 1 month ago

Availability: Fri afternoon, Sat-Mon all day ETA: Sunday 8/4 EOD Updated to Friday 8/9 EOD

daras-cu commented 2 weeks ago

Weekly update:

Progress: I have completed work on this issue and opened a PR (#7262). I made requested changes from one reviewer. Blockers: I am waiting on a second review. Availability: Saturday-Monday all day, weekday evenings ETA: Unknown, waiting on review