Refactor "Update VMRS data" to fetch required data

[FamousHero]

Dependency

• [ ] #7524

Overview

We are currently storing excess data in vrms_data.json. We need to store only necessary data to make the website work. See

Details

Currently, all data fetched from the VRMS API is being saved. This means we are exposing unnecessary information to end users. We should only update required information and delete everything else in order to ensure data privacy, protection & security. Required data under resources

Action Items

• [ ] Create a new folder in github-actions/trigger-schedule named vrms-data
  • [ ] In that new folder create a new file named filter-vrms-data.js
• [ ] Write the code required to filter the vrms data & save it to _data/external/vrms_data.json
• [ ] Integrate the new file with the "Update VMRS data" workflow
• [ ] Test the workflow in your repo and demonstrate that your solution works.
• [ ] Test that all pages that rely on vrms_data.json are unchanged

Resources/Instructions

• This issue was initiated by #6145
• Hack for LAs GitHub Actions
• Required data specified in this issue: https://github.com/hackforla/website/issues/7524
• Pages that use vrms_data.json
  • https://www.hackforla.org/projects/311-data (any project page like this) has event data
  • https://www.hackforla.org/events/ has event data
  • https://www.hackforla.org/project-meetings

[ExperimentsInHonesty]

@FamousHero What is missing from this is the instruction to test the pages that the data appears on

• Pages project data event data appears on
  • https://www.hackforla.org/projects/311-data (any project page like this) has event data
  • https://www.hackforla.org/events/ has event data
  • https://www.hackforla.org/project-meetings

[HackforLABot]

Hi @FamousHero, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

[FamousHero]

@bonniewolfe Added an extra test to check that site is unchanged afterwards & linked the related pages in Resources/Instructions

[ExperimentsInHonesty]

@t-will-gillis will look at the method you are using and approve or give notes

[t-will-gillis]

Hey @FamousHero Thanks for taking care of this- this is looking great so far. Here are a couple of notes/suggestions/discussion topics:

• I feel that this should be bumped up from size: 2pt- I think it’s at least a size: 5pt job. Thoughts?
• The “Overview” ends with ‘…See’- was there something additional here?
• I would consider being more direct about this being a GitHub Actions issue, for example adding “GHA” to the title, something like: 'Refactor GHA “Update VRMS data” to fetch required data'
• In the “Action Items”, I agree with each of the steps and the file structure you want created.
• I think it would be good to consider starting the “Action Items” by having the dev refer to the Hack for LA’s GitHub Actions for guidance from the start. The reason for this is that although there are many workable ways to write the code, I think we want to nudge the dev into using a similar framework as we use in all of our other GHAs (that is Hack for LA’s “GitHub Actions Architecture” as the document states) because this makes our lives easier when reviewing, editing, troubleshooting, etc.
• I might reorder the bullet points and place the ‘…“Update VRMS data” workflow’ as the first point, but if you keep the order, I would still note that the workflow is triggered from the vrms-data.yml file, and that the .yml is calling the filter-vrms-data.js file.
• One other thing, I like to give the links within the text for the files to be worked, i.e. vrms-data.yml Some others like to use footnotes and put the links in the “Resources/Instructions”.

Hope this is useful. Let me know if you would like to discuss anything