ER: Skills Issue link to PRs that require review

[roslynwythe]

Emergent Requirement - Problem

Section 9 of the Skills Issue template contains a problematic link to "good first issue" PRs that require review. The link includes a filter for 'review required'. Currently the ghpages branch is configured to require only 1 reviewer, however in fact HfLA generally requires the approval of two reviewers before merging Pull Requests. Therefore the use of the 'review required' term in the filter is too restrictive, because it excludes PRs that already have a single reviewer, but require a second reviewer.

Details - this is the relevant section

9 - GOOD FIRST ISSUE (GFI) PULL REQUEST REVIEWS

Now that you have two merged good first issue PRs, you are eligible to review good first issue PRs, Review Required from other people who are following in the same journey path as you.

Setting for required reviews


Issue you discovered this emergent requirement in

Not an issue. It was raised in Thursday office hours on 9/27/2024when a developer mentioned that the above link resulted in an empty list of PRs.

Date discovered

9/27/2024

Did you have to do something temporarily

• [ ] YES
• [ ] NO

Who was involved

@roslynwythe @DrAcula27

What happens if this is not addressed

Developers will believe that there are no "good first issue" PRs available to review, potentially delaying their progress and creating confusion.

Resources

Recommended Action Items

• [x] Make a new issue
• [x] Discuss with team
• [ ] Let a Team Lead know

Potential solutions [draft]

• Update the branch protection settings for ghpages so that 2 reviews are required. OR
• Create an issue to update the link (filter) to remove "review required"

[github-actions[bot]]

Hi @roslynwythe.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:

• Complexity, Role, Feature

NOTE: Please ignore this comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards. To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

• Wiki: How to create issues
• Wiki: How to read and interpret labels

[roslynwythe]

@ExperimentsInHonesty please advise re: potential solutions.