hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
325 stars 778 forks source link

Replace label in project-profile-card-review-and-update.yml #7606 #7660

Open ihop-56 opened 3 weeks ago

ihop-56 commented 3 weeks ago
Fixes #7606 ### What changes did you make? - Updated the issue template to replace ready for dev lead with ready for merge team in the project-profile-card-review-and-update.yml file. ### Why did you make the changes (we will use this info to test)? - The change was requested to streamline issue review processes, allowing the merge team to handle more issue reviews effectively.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown ![Screenshot 2024-10-28 154514](https://github.com/user-attachments/assets/ea66c586-c14c-45fd-8705-1c116224e704)
Please let us know that you have checked for CodeQL alerts. **Please do not dismiss alerts.** - [ ] I have checked this PR for CodeQL alerts and none were found. - [ ] I found CodeQL alert(s), and (select one): - [ ] I have resolved the CodeQL alert(s) as noted - [ ] I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate) - [ ] I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts If CodeQL alert/annotations appear, refer to [How to Resolve CodeQL alerts](https://github.com/hackforla/website/issues/6463#issuecomment-2002573270). In general, CodeQL alerts should be resolved prior to PR reviews and merging
### For Reviewers - Use this URL to check the updated issue template: [https://github.com/ihop-56/website/issues/1] ### Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes) - No visual changes to the website
github-actions[bot] commented 3 weeks ago

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b ihop-56-replace-label-in-project-profile-card-7606 gh-pages
git pull https://github.com/ihop-56/website.git replace-label-in-project-profile-card-7606
dcotelessa commented 3 weeks ago

ETA: 1 hour Availability: 4-6 W Th F

codyyjxn commented 3 weeks ago

ETA: EOD Availability: M > F

dcotelessa commented 3 weeks ago

Good job!

siyunfeng commented 3 weeks ago

Review ETA: 11/1/2024 Friday Availability: 7-10 PM Weekdays (EDT)

siyunfeng commented 1 week ago

Hi @ihop-56 , please make the changes we requested. Feel free to reach out if you have any questions.

ihop-56 commented 5 days ago

Hi @siyunfeng and team, the requested changes have been made:

t-will-gillis commented 5 days ago

Hello @ihop-56 Please provide an update on when you will be able to wrap up this PR. Thanks

ihop-56 commented 5 days ago

Hello @ihop-56 Please provide an update on when you will be able to wrap up this PR. Thanks

End of this week

siyunfeng commented 4 days ago

Hi @siyunfeng and team, the requested changes have been made:

  • Fixed the extra space in the syntax to align with the existing front matter block.
  • I'm not sure how to update the "For Reviewers" section with the correct issue template URL. Could you please help me with this?

Fixed the extra space in the syntax to align with the existing front matter block.

I still can see the extra spaces in line 353.

I'm not sure how to update the "For Reviewers" section with the correct issue template URL. Could you please help me with this?

The file you made the change on was .github/ISSUE_TEMPLATE/project-profile-card-review-and-update.yml. Its corresponding issue template should be Project Profile Card review and update, and the issue template you used was Project Profile leader updates - Add.

I don't see the Project Profile Card review and update issue template in your repo, it could be an issue from when you forked from the original repo.

ihop-56 commented 4 hours ago

@siyunfeng Hi, Can you check again? I have fixed the extra space and I'm not able to find the Project Profile Card review and update template in my repo

siyunfeng commented 3 hours ago

@siyunfeng Hi, Can you check again? I have fixed the extra space and I'm not able to find the Project Profile Card review and update template in my repo

Hi @ihop-56 , I can see the Project Profile Card review and update issue template in your repo.

Because the original issue is missing the instructions for creating corresponding labels for the template, you will need to complete this PR with the following steps:

Once you create all the labels listed in the file /.github/ISSUE_TEMPLATE/project-profile-card-review-and-update.yml in your repo, you should be able to see the corresponding labels appear in the issue template.

You can re-request me to review your PR once you complete the steps above.