Open ihop-56 opened 3 weeks ago
Want to review this pull request? Take a look at this documentation for a step by step guide!
From your project repository, check out a new branch and test the changes.
git checkout -b ihop-56-replace-label-in-project-profile-card-7606 gh-pages
git pull https://github.com/ihop-56/website.git replace-label-in-project-profile-card-7606
ETA: 1 hour Availability: 4-6 W Th F
ETA: EOD Availability: M > F
Good job!
Review ETA: 11/1/2024 Friday Availability: 7-10 PM Weekdays (EDT)
Hi @ihop-56 , please make the changes we requested. Feel free to reach out if you have any questions.
Hi @siyunfeng and team, the requested changes have been made:
Hello @ihop-56 Please provide an update on when you will be able to wrap up this PR. Thanks
Hello @ihop-56 Please provide an update on when you will be able to wrap up this PR. Thanks
End of this week
Hi @siyunfeng and team, the requested changes have been made:
- Fixed the extra space in the syntax to align with the existing front matter block.
- I'm not sure how to update the "For Reviewers" section with the correct issue template URL. Could you please help me with this?
Fixed the extra space in the syntax to align with the existing front matter block.
I still can see the extra spaces in line 353.
I'm not sure how to update the "For Reviewers" section with the correct issue template URL. Could you please help me with this?
The file you made the change on was .github/ISSUE_TEMPLATE/project-profile-card-review-and-update.yml
. Its corresponding issue template should be Project Profile Card review and update, and the issue template you used was Project Profile leader updates - Add
.
I don't see the Project Profile Card review and update
issue template in your repo, it could be an issue from when you forked from the original repo.
@siyunfeng Hi, Can you check again? I have fixed the extra space and I'm not able to find the Project Profile Card review and update template in my repo
@siyunfeng Hi, Can you check again? I have fixed the extra space and I'm not able to find the Project Profile Card review and update template in my repo
Hi @ihop-56 , I can see the Project Profile Card review and update issue template in your repo.
For Reviewers
section (No need to create an issue)CodeQL Alerts
sectionBecause the original issue is missing the instructions for creating corresponding labels for the template, you will need to complete this PR with the following steps:
Browse to the Issues page, then click Labels
hackforla/website
repository, but the text of the labels must match exactly. Once you create all the labels listed in the file /.github/ISSUE_TEMPLATE/project-profile-card-review-and-update.yml
in your repo, you should be able to see the corresponding labels appear in the issue template.
You can re-request me to review your PR once you complete the steps above.
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
![Screenshot 2024-10-28 154514](https://github.com/user-attachments/assets/ea66c586-c14c-45fd-8705-1c116224e704)Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to [How to Resolve CodeQL alerts](https://github.com/hackforla/website/issues/6463#issuecomment-2002573270). In general, CodeQL alerts should be resolved prior to PR reviews and merging