hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
325 stars 778 forks source link

Refactor GHAs so templates use `label-directory.json` #7688

Closed t-will-gillis closed 4 days ago

t-will-gillis commented 3 weeks ago
Fixes #7687 ### What changes did you make? - Refactored `check-labels.js` so that templates labeled with `Template Label Placeholder` will trigger a function to find labelKeys in the body comments and then convert these to labelNames. - Refactored `blank-issue-template.md` and `inactive-members.md` as example cases of how this will work. The remaining templates will be changed in a later issue. ### Why did you make the changes (we will use this info to test)? - Providing the supporting functionality so that templates will use labelKeys and reference the `label-directory.json`

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown ![Screenshot 2024-10-28 154514](https://github.com/user-attachments/assets/ea66c586-c14c-45fd-8705-1c116224e704)
Please let us know that you have checked for CodeQL alerts. **Please do not dismiss alerts.** - [ ] I have checked this PR for CodeQL alerts and none were found. - [x] I found CodeQL alert(s), and (select one): - [x] I have resolved the CodeQL alert(s) as noted - [ ] I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate) - [ ] I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts If CodeQL alert/annotations appear, refer to [How to Resolve CodeQL alerts](https://github.com/hackforla/website/issues/6463#issuecomment-2002573270). In general, CodeQL alerts should be resolved prior to PR reviews and merging
### Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes) - No visual changes - Test logs and screenshots to follow
github-actions[bot] commented 3 weeks ago

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-refactor-gha-templates-labels-7687 gh-pages
git pull https://github.com/t-will-gillis/website.git refactor-gha-templates-labels-7687
t-will-gillis commented 4 days ago

The specific task to use label key values on the template files will be addressed in a future issue.