Open roslynwythe opened 2 hours ago
Hi @roslynwythe.
Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:
NOTE: Please ignore this comment if you do not have 'write' access to this directory.
To add a label, take a look at Github's documentation here.
Also, don't forget to remove the "missing labels" afterwards. To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.
After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.
Additional Resources:
@ExperimentsInHonesty I want to mention that while this issue relates to the GitHub icon, I believe a similar situation exists with the LinkedIn icon. I'm not sure if we should address the LinkedIn icon in this ER or a different one.
Emergent Requirement - Problem
The wins overlay (which appears when the user expands a wins card using "See More" link) contains a reference to
/assets/images/wins-page/icon-github-small.svg
, and we would like to replace that reference with a reference to_includes/svg/icon-github.svg
.Issue you discovered this emergent requirement in
6911
Date discovered
12/18/2024
Did you have to do something temporarily
Who was involved
@roslynwythe
What happens if this is not addressed
Resources
6911
pages/wins/wins.html
_includes/wins-page/wins-overlay.html
6654
/assets/js/wins.js
Recommended Action Items
Potential solutions [draft]
updateOverlay
and in the templatewins-overlay.html
, and the changes are a bit more complex due to more complex JS involved.