search

hackforla / website

Hack for LA's website
https://www.hackforla.org
GNU General Public License v2.0
325 stars 778 forks source link

remove Emma Thrash from Expunge Assist #7705 #7733

Closed codyjohnsontx closed 4 days ago

codyjohnsontx commented 6 days ago
Fixes #7705 ### What changes did you make? - Remove Emma Thrash from Expunge Assist Current Team ### Why did you make the changes (we will use this info to test)? - To keep list of Current Project Team up to date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown ![Screenshot 2024-10-28 154514](https://github.com/user-attachments/assets/ea66c586-c14c-45fd-8705-1c116224e704)
Please let us know that you have checked for CodeQL alerts. **Please do not dismiss alerts.** - [x] I have checked this PR for CodeQL alerts and none were found. - [ ] I found CodeQL alert(s), and (select one): - [ ] I have resolved the CodeQL alert(s) as noted - [ ] I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate) - [ ] I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts If CodeQL alert/annotations appear, refer to [How to Resolve CodeQL alerts](https://github.com/hackforla/website/issues/6463#issuecomment-2002573270). In general, CodeQL alerts should be resolved prior to PR reviews and merging
### Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied ![emma_thrash_before](https://github.com/user-attachments/assets/89c39a16-10ad-4623-9bd3-7632dbc9d90e)
Visuals after changes are applied ![emma_thrash_after](https://github.com/user-attachments/assets/8026af00-a508-440e-98a7-747347cae4a0)
github-actions[bot] commented 6 days ago

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b codyjohnsontx-remove-emma-thrash-7705 gh-pages
git pull https://github.com/codyjohnsontx/website.git remove-emma-thrash-7705
mchait18 commented 5 days ago

Review ETA: 12 PM 11/20/24 Availability: 9-3 EST M-F

belunatic commented 4 days ago

Review ETA: 12 PM 11/22/24 Availability: 4-5 M

codyjohnsontx commented 4 days ago

Update

  1. All finished, made notes in my own documentation about what to do better according to the reviews above. Only awaiting merge pull request to delete branch and continue on
  2. None
  3. M-F 3-7pm, 9pm-10pm
  4. ETA: EOD 11/21/24