search

hackforwesternmass / foodfinder

Food Bank of Western Mass food Finder
4 stars 0 forks source link

Refactor & Clean up SCSS/HTML #9

Closed patrickbrown-dev closed 10 years ago

patrickbrown-dev commented 10 years ago

This ticket is based on a brief conversation with @asoules before I left. The front-end code is kind of a mess right now (scss and js) and needs to be refactored. For example the mustache templating code lives in ajax.js.

Is this a good time to implement angular?

asoules commented 10 years ago

Angular is a perfect candidate for this app. It would be a single controller, with a single service. Hard to say how difficult it will be. I can put a skeleton together in a branch, then we can go from there?

patrickbrown-dev commented 10 years ago

Sounds good!

andyanderson commented 10 years ago

Sounds good to me.

On Jun 9, 2014, at 9:25 AM, Aaron Soules wrote:

Angular is a perfect candidate for this app. It would be a single controller, with a single service. Hard to say how difficult it will be. I can put a skeleton together in a branch, then we can go from there?

— Reply to this email directly or view it on GitHubhttps://github.com/hackforwesternmass/foodfinder/issues/9#issuecomment-45489848.

asoules commented 10 years ago

Created issue #20 for angular re-build. Renaming this issue to represent SCSS refactoring.

patrickbrown-dev commented 10 years ago

Can somebody aside from me look at the sass-restructure branch and do a quick code review before we merge to master? Thanks :)

asoules commented 10 years ago

Send a pull request to master and I'll take a look!