hackgvl / hackgreenville-com

HackGreenville's Website
https://hackgreenville.com
MIT License
16 stars 15 forks source link

Contact Page: Improve Responsive Design for Mobile, Tablet #125

Closed bogdankharchenko closed 1 year ago

bogdankharchenko commented 1 year ago

Before

hackgreenville com_contact

After

hackgreenville-com test_contact (1)

bogdankharchenko commented 1 year ago

I will need to submit another PR to make changes to the slack join page as well.

allella commented 1 year ago

Thanks. @oliviasculley may want to take a look.

oliviasculley commented 1 year ago

I'd like to loop in @zach2825, since he has much more experience with the Laravel ecosystem than I do (basically none lol) :smile: It seems a lot of changes in this PR are mostly from formatting and indention, is there some sort of linter we can use to help standardize our templates?

allella commented 1 year ago

We have a PR for the linter too. https://github.com/codeforgreenville/hackgreenville-com/pull/122

If Zach blesses these things, then we can move forward on them.

bogdankharchenko commented 1 year ago

This PR is not changing any white space/formatting. The intention is to make the page responsive for Small devices

oliviasculley commented 1 year ago

This PR is not changing any white space/formatting. The intention is to make the page responsive for Small devices

This PR seems to have a lot of unnecessary indentation changes. I've attached a couple examples from the Github diff UI, but ideally once we have the linter in place then these differences should get linted out 2022-09-08_13-09-1662659297 2022-09-08_13-09-1662659307

bogdankharchenko commented 1 year ago

Oh yea sure. I'm all for linting.

allella commented 1 year ago

It looks like the biggest difference is adding the hcaptcha JS file include into the Laravel Blade 'script' stack. Everything else looks like classes and indent changes.

@oliviasculley if you're good with it then we'll merge.

bogdankharchenko commented 1 year ago

I say merge either merge or close this - nothing worse than stale PR's =D

oliviasculley commented 1 year ago

Sorry I never replied, it looks good to me but I don't really have any Laravel experience, so if it looks good to you or Zach then I'm good with it :smile: