Closed bogdankharchenko closed 1 year ago
I will need to submit another PR to make changes to the slack join page as well.
Thanks. @oliviasculley may want to take a look.
I'd like to loop in @zach2825, since he has much more experience with the Laravel ecosystem than I do (basically none lol) :smile: It seems a lot of changes in this PR are mostly from formatting and indention, is there some sort of linter we can use to help standardize our templates?
We have a PR for the linter too. https://github.com/codeforgreenville/hackgreenville-com/pull/122
If Zach blesses these things, then we can move forward on them.
This PR is not changing any white space/formatting. The intention is to make the page responsive for Small devices
This PR is not changing any white space/formatting. The intention is to make the page responsive for Small devices
This PR seems to have a lot of unnecessary indentation changes. I've attached a couple examples from the Github diff UI, but ideally once we have the linter in place then these differences should get linted out
Oh yea sure. I'm all for linting.
It looks like the biggest difference is adding the hcaptcha JS file include into the Laravel Blade 'script' stack. Everything else looks like classes and indent changes.
@oliviasculley if you're good with it then we'll merge.
I say merge either merge or close this - nothing worse than stale PR's =D
Sorry I never replied, it looks good to me but I don't really have any Laravel experience, so if it looks good to you or Zach then I'm good with it :smile:
Before
After