Closed zach2825 closed 11 months ago
livewire modals - https://github.com/wire-elements/modal
@zach2825 if this is ready to merge, then please let me know what commands to run to avoid blowing things up.
We still have https://stage.hackgreenville.com so it will be deployed there first to test.
Sorry, I see this is the one you said was not ready.
Could you post any deploy commands on the other PRs that are ready so I can pull them to stage and run the commands and check that things are good before doing the same on the live site?
All resolved @allella
I can't remember the current process to deploy these changes.
Deploys now should do these:
yarn install
composer install
yarn build
@zach2825 this is showing conflicts too.
Please let me know if you when you want to merge this and if we should go live with the previous two PRs now, or merge all PRs, test, and go live in one shot.
Thanks
@allella, sorry about that; all resolved should not happen going forward. These few PRs contained a lot of changes that depended on each other.
@zach2825 I'm about to merge this into the develop branch and test on stage.
On the stage server, should I run all of the following?
yarn install composer install yarn build
Also, it looks like there's are two new VITE .env variables I need to copy from .env.example, correct?
Hey @allella,
No, you should not need those. Those variables changed for vite, so I wanted to update them so if anybody wants to use them in the future, they will be more accurate. They are just for push notifications using web sockets.
Yes, those three should be the only commands. That's all I had to run locally when testing these changes.
Also, I added the VITE variables to the .env and removed the old MIX variables.
- MIX_PUSHER_APP_KEY="${PUSHER_APP_KEY}"
- MIX_PUSHER_APP_CLUSTER="${PUSHER_APP_CLUSTER}"
+ VITE_PUSHER_APP_KEY="${PUSHER_APP_KEY}"
+ VITE_PUSHER_APP_CLUSTER="${PUSHER_APP_CLUSTER}"
On another note, do the PUSHER variables all need to be set in .env? If so, what's the context for deciding what to set them to?
@zach2825 nevermind, I see you were telling me I don't need the VITE vars and I read it quickly to mean that the commands above weren't needed.
I ran the three commands on stage and it's unbroken. https://stage.hackgreenville.com
Are the three yarn and composer commands something we should always run on deploys? If so, shall we add these do the README?
PRs #139 #137 and #134 are now live. Thanks @zach2825
Closes #135