search

hackgvl / open-map-data-multi-layers-demo

A bookmarkable map displaying all layers from HackGreenville Labs' Open Map Data
https://hackgvl.github.io/open-map-data-multi-layers-demo/
MIT License
2 stars 2 forks source link

Add an Attribution Banner to Map with Contribution Link #17

Closed ThorntonMatthewD closed 9 months ago

ThorntonMatthewD commented 9 months ago

Summary

Adds an attribution control element to the bottom-right corner of the map. It lets anyone who navigates to the homepage know who is behind the project and where they can go to get involved.

I've also added in attribution to OpenStreetMap for the base layer.

Screenshots

Desktop

Screenshot_2023-10-07_23-47-58

Mobile

Screenshot_2023-10-07_23-45-21

Testing Plan

  1. The attribution control bar will be visible in the bottom-right corner of the map whenever the main page is loaded.
  2. Ensure that the three hyperlinks contained within all are oeprational and take you to the expected pages.
ThorntonMatthewD commented 9 months ago

I think I'd like to explore other options for addressing #11 to prevent things from getting too cramped, but I thought this was a positive change on its own.

oliviasculley commented 9 months ago

@all-contributors add @ThorntonMatthewD as a contributor for code, test

allcontributors[bot] commented 9 months ago

@oliviasculley

I've put up a pull request to add @ThorntonMatthewD! :tada: