Fix some fun browser errors

hackgvl / open-map-data-multi-layers-demo

A bookmarkable map displaying all layers from HackGreenville Labs' Open Map Data

https://hackgvl.github.io/open-map-data-multi-layers-demo/

MIT License

2 stars 2 forks source link

Fix some fun browser errors #24

Closed oliviasculley closed 1 year ago

oliviasculley commented 1 year ago

Fix attribution icon not showing up
Fix browser error when initially loading map
Adds sourcemaps to public build

ThorntonMatthewD commented 1 year ago

Map -- adds a map layer and changes URL (failed) Map -- Maintainer Control -- The Maintainer Control disappears if all layers are unchecked (failed) Map -- unchecks a map layer and changes URL (failed)

Each of these three tests look like they stalled out somewhere before the first assertion. I am not experiencing this behavior locally... :snowflake: y?

oliviasculley commented 1 year ago

I'm managing to reproduce it locally if I run npm ci && npm run test:e2e, but that isn't really helping with finding out the cause, looks like it's time to pull out git bisect for the second time tonight :sob:

oliviasculley commented 1 year ago

Yep, git bisect confirmed it was the npm audit fix --force. However, using git bisect run is pretty cool :smile: