hackgvl / open-map-data-multi-layers-demo

A bookmarkable map displaying all layers from HackGreenville Labs' Open Map Data
https://hackgvl.github.io/open-map-data-multi-layers-demo/
MIT License
2 stars 2 forks source link

Added the required tests, except for tab rendering #3

Closed eitan-lich closed 1 year ago

eitan-lich commented 1 year ago

Hi, i havent added tests for the tabs rendering as i didn't completely understand what it meant.

oliviasculley commented 1 year ago

Hello, this looks fantastic!! However could you modify this PR to merge into codeforgreenville:develop? I want to get github actions set up to automatically run these tests before they're merged into stable (which will automatically deploy it to the website). Thank you so much!!!

oliviasculley commented 1 year ago

nevermind I was able to change the merge target :sweat_smile: Thank you so much!

oliviasculley commented 1 year ago

So, after playing around with the tests, it turns out that cypress is a lot more complicated than I thought... I made the tests a bit more assertive and tried to remove the hardcoded wait times as recommended by the linter, which in turn broke the tests for various reasons, so here are some of the things that I learned:

all of this to say:

These changes are in https://github.com/codeforgreenville/open-map-data-multi-layers-demo/commit/d79a6d36966239790a1e38172a63b9bea15901d4 if you'd like to look at them!

eitan-lich commented 1 year ago

Ok thank you very much.