Closed eitan-lich closed 1 year ago
Hello, this looks fantastic!! However could you modify this PR to merge into codeforgreenville:develop
? I want to get github actions set up to automatically run these tests before they're merged into stable
(which will automatically deploy it to the website). Thank you so much!!!
nevermind I was able to change the merge target :sweat_smile: Thank you so much!
So, after playing around with the tests, it turns out that cypress is a lot more complicated than I thought... I made the tests a bit more assertive and tried to remove the hardcoded wait times as recommended by the linter, which in turn broke the tests for various reasons, so here are some of the things that I learned:
cy.url().should
to allow cypress to wait for the url to change, instead of doing .then() on whatever the current url is at the time (which cypress will just run instantly)lat
, lng
and zoom
query parameters on first load, so we can wait for all of them to be present for the map to finish loadingall of this to say:
These changes are in https://github.com/codeforgreenville/open-map-data-multi-layers-demo/commit/d79a6d36966239790a1e38172a63b9bea15901d4 if you'd like to look at them!
Ok thank you very much.
Hi, i havent added tests for the tabs rendering as i didn't completely understand what it meant.