hackgvl / open-map-data-multi-layers-demo

A bookmarkable map displaying all layers from HackGreenville Labs' Open Map Data

https://hackgvl.github.io/open-map-data-multi-layers-demo/

MIT License

2 stars 2 forks source link

Add Contribution Button and Some CSS Tweaks #31

Closed ThorntonMatthewD closed 8 months ago

ThorntonMatthewD commented 8 months ago

Summary

A "Learn how to contribute!" button was added to the bottom nabvar
A CSS bug where the attribution control was cut off on the map was fixed.
All copy that read "Click here to..." had that portion removed.
Set the links in the attribution control be open new tabs whenever clicked.

Screenshots

Desktop

Screenshot_2023-10-16_19-30-24

Mobile

Screenshot_2023-10-16_19-30-47

Testing Plan

The "Learn how to contribute!" button should appear at the bottom of all pages.
The banner at the top of the page should read "Learn how to contribute" also.
The attribution control should visible, and the links therein should open new tabs whenever clicked.
The map should fill the entire space between the banner (or top of page if banner is absent) to the top of the navbar, and not overhang, at any screen size.

ThorntonMatthewD commented 8 months ago

Looks great!!

Thank you so much for taking a look at this. I really appreciate it!