hackiftekhar / IQActionSheetPickerView

ActionSheet with UIPickerView
MIT License
205 stars 76 forks source link

iPhone X #27

Closed brightsider closed 6 years ago

brightsider commented 6 years ago

Please, add support of iPhone X

brightsider commented 6 years ago
screen
jevenson commented 6 years ago

Can you explain what's wrong with your screen shot?

brightsider commented 6 years ago

Needs to add spacing to bottom.

hackiftekhar commented 6 years ago

Fixed and released 1.0.8.

brightsider commented 6 years ago

Spacing ok, but this zone is not swipes, but should by Apple Guidelines. Please, fix it :) footer

hackiftekhar commented 6 years ago

Can you please explain more about the swipe you are talking about?

brightsider commented 6 years ago

https://developer.apple.com/ios/human-interface-guidelines/overview/iphone-x/

Avoid explicitly placing interactive controls at the very bottom of the screen and in corners. People use swipe gestures at the bottom edge of the display to access the Home screen and app switcher, and these gestures may cancel custom gestures you implement in this area. The far corners of the screen can be difficult areas for people to reach comfortably.

brightsider commented 6 years ago

Can't go to Home via iOS native gesture for iPhone X.

hackiftekhar commented 6 years ago

@brightsider actually that's out of control, I did the best I can do. Here are the technical details:-

Did you find anything I might be missing or doing wrong here? I would be glad to hear @brightsider and eager to fix.

brightsider commented 6 years ago

@hackiftekhar PickerView put in UIView that has spacing between bottom constraints equals to safeAreaInset.bottom