hackingmaterials / atomate

atomate is a powerful software for computational materials science and contains pre-built workflows.
https://hackingmaterials.github.io/atomate
Other
242 stars 174 forks source link

Structure Optimization may not be converged with respect to kpts #280

Open shyamd opened 5 years ago

shyamd commented 5 years ago

I think we've somewhat known about this, but it can crop up in unwanted ways. Currently, even with the double relaxation, we don't update the kpts for the new volume in between relaxation runs. The result is that while the volume may stop changing from one relaxation to the next, the volume change during the relaxation makes it so the kpts is not appropriate, leading to bad energies, stresses, forces, etc.

We're partially dealing with this in Emmet by having task validation, but the Structure Opt Firework should probably do some extra legwork to make sure everything is converged OR some extra validation.

shyuep commented 5 years ago

This should be part of the mods to relaxation parameters that we were discussing for smearing, force convergence, etc.