search

hackingmaterials / matminer

Data mining for materials science
https://hackingmaterials.github.io/matminer/
Other
480 stars 194 forks source link

Skip the thermo tests rather than crash if MP API is missing #905

Closed ml-evs closed 1 year ago

ml-evs commented 1 year ago

For the current released pymatgen version, creating an MPRester without an API key will raise a ValueError. This is fixed in the main pymatgen branch, but for now, this PR allows the tests to skip when no MP API key is present (as intended by the original code).

This should fix the test errors seen in #892 for @gbrunin.