hackingmaterials / matminer

Data mining for materials science

https://hackingmaterials.github.io/matminer/

Other

466 stars 191 forks source link

Re-enable tests that are skipped in CI #923

Closed ml-evs closed 5 months ago

ml-evs commented 7 months ago

922 disables some tests as they do not work with the latest numpy/pandas combo. This may be because the test code itself is broken, or bad numpy/pandas calls are being made in the featurizer or an upstream dep.

JaGeo commented 7 months ago

@ml-evs Should one also dis-enable the corresponding featurizers as well for now? See https://github.com/hackingmaterials/matminer/issues/915#issuecomment-1933160620

ml-evs commented 7 months ago

@ml-evs Should one also dis-enable the corresponding featurizers as well for now? See https://github.com/hackingmaterials/matminer/issues/915#issuecomment-1933160620

Yeah I think that's next on the list, I just want to verify that it's not the test cases themselves that are the problem first

ml-evs commented 5 months ago

Closed by #925