Added missing `impute_nan` for `WenAlloys` and removed unnecessary warning - Githubissues

hackingmaterials / matminer

Data mining for materials science

https://hackingmaterials.github.io/matminer/

Other

466 stars 191 forks source link

Added missing `impute_nan` for `WenAlloys` and removed unnecessary warning #937

Closed gbrunin closed 4 months ago

gbrunin commented 4 months ago

Summary

This fixes 2 small things:

A warning about NaN imputation was written in case ElementProperty was initialiazed with impute_nan=False, even though the data source could be itself initialized with impute_nan=True. The warning is removed, since the imputation is only happening at the level of the data source.
I missed an imputation in WenAlloys featurizer.

I'm make some tests now to decide whether the default of impute_nan should be switched to True.