hackingmaterials / matminer_examples

A repo of examples for the matminer (https://github.com/hackingmaterials/matminer) code
Other
103 stars 60 forks source link

PlotlyFig examples - use matminer data sets? #3

Closed computron closed 6 years ago

computron commented 6 years ago

@ardunn @albalu

Should the PlotlyFig examples use the matminer example data sets?

albalu commented 6 years ago

We are mostly using matminer example data sets except: 1) 1 simple plot for each example to make sure data format is clear (e.g. pf.xy(([1, 2], [2, 4])) ) 2) that one example where I used boston because I couldn't make heatmap_df look nice with our datasets I can try harder to make a nice looking example for heatmap_df using our dbs instead of boston. For now, please feel free to take it out if that's the only example making matminer_examples dependent on sklearn.

computron commented 6 years ago

@albalu I didn't look carefully, I guess the first example I clicked was the Boston one and I assumed they were all like that.

I'll leave this issue open, I do think you should

albalu commented 6 years ago

9 should address this.