hackingmaterials / matminer_examples

A repo of examples for the matminer (https://github.com/hackingmaterials/matminer) code
Other
103 stars 60 forks source link

Typo and API key shown in notebook #40

Closed utf closed 6 years ago

utf commented 6 years ago

I've noticed a couple of typos and other minor bugs in the basic data retrieval notebook. I will keep track of them in this issue and submit a pull request containing fixes when I've run through all the notebook examples.

In data_retrieval_basics.ipynb:

(I'll edit this message if I find anything else)

ardunn commented 6 years ago

Whoops, these are from when @albalu and I did the MP workshop and forgot to change things back.

@albalu your API key is showing!

albalu commented 6 years ago

That was public information the moment we put it up in the git log, I tried to change my key after the workshop but it seemed like Citrine didn't have this option. Thanks @utf for noticing these.

computron commented 6 years ago

@utf can you go ahead and issue some PRs to fix?

I'm not really so concerned about the key being in the log, let's just get it off the live example