search

hackingmaterials / pv-vision

Image analysis tool for solar modules, assisted by deep learning.
BSD 3-Clause "New" or "Revised" License
35 stars 8 forks source link

non interactive code #9

Closed Eneko82 closed 1 year ago

Eneko82 commented 1 year ago

• We would like to run this code in python file (.py). To that end we have commented (#) interactive function and define the functions parameters manually. For example: image

Please find attached the modified notebook which no interative imput of parameters(NoNinteractive.ipynb). This works well for the mask generation (update_mask), corners detection (update corners) and update edges function. However, when we reached to cells cropping, we get this error:

image

After debugging it seems that interactive function is really needed for update edges function. We don’t want to modify your update edges function. So, the question is, is it possible to call this function without using interactive in .py file? Or interactive is needed ? or there is another problem which cells cropping?

X-Chen97 commented 1 year ago

Could you please provide more details when you run this code in jupyter notebook? That is to say, can you process this module image in an interactive mode?

I want to check if this issue is triggered by interactive code or failure of detecting internal peaks.

X-Chen97 commented 1 year ago

I am going to close this issue. If you meet new problems, feel free to ask!