search

hackintosh-stuff / ComboJack

Hackintosh combojack support for alc256/alc255.
175 stars 70 forks source link

Add 0xc0 Line for Realtek ALC256 to restore some bass loss through headphones #8

Open Andrw0830 opened 5 years ago

Andrw0830 commented 5 years ago

My codec through Linux has 0xC0 defined for 0x21 node. I've noticed with my codec with testing that without this line I am missing some bass when I play media through the headphone jack and sound has too much treble. This restores the bass and audio still sounds good without noise.

maz-1 commented 5 years ago

Are you sure this patch is adaptable to all alc255/alc256 variants?

Andrw0830 commented 5 years ago

Are you sure this patch is adaptable to all alc255/alc256 variants?

That's the one thing I am not sure and hope someone else can test/verify. I know for my SubVendor 10280798 it is there and without it, audio is not as good through headphones.

Andrw0830 commented 5 years ago

Hey man wanted to update you. I did have the-darkvoid test this change and since his laptop is a XPS, this line doesn't get applied. I wish I knew someone who has the ALC256 variant that those lines would apply too. Hopefully someone sees this request and can comment.

maz-1 commented 4 years ago

Try to modify source according to this patch: https://github.com/torvalds/linux/commit/717f43d81afc1250300479075952a0e36d74ded3#diff-6cb60ab78549a5b6838f746b9e128105

Andrw0830 commented 4 years ago

I don't know much about editing the audio source to do that. I just found that my ALC256 linux dump shows Node 0x21 has 0xc0 defined so added it here. Is it possible you can help me out? Also wanted to ask, when using ComboJack with the ALC256, I get the antipop sound from MacOS after a few seconds when the codec goes to sleep. It doesn't happen every time, but when you have headphone on and suddenly hear a pop, it doesn't feel good on your ears. It seems to happen more with using ComboJack, but is there a way to disable that?

Thanks for your work!

maz-1 commented 4 years ago

I don't know much about editing the audio source to do that. I just found that my ALC256 linux dump shows Node 0x21 has 0xc0 defined so added it here. Is it possible you can help me out? Also wanted to ask, when using ComboJack with the ALC256, I get the antipop sound from MacOS after a few seconds when the codec goes to sleep. It doesn't happen every time, but when you have headphone on and suddenly hear a pop, it doesn't feel good on your ears. It seems to happen more with using ComboJack, but is there a way to disable that?

Thanks for your work!

I'm just a bit busy to adopt and test the patch. I have defined all the macros needed, so it should't be that hard :-)