upstream to Google WebRTC codebase - Githubissues

hackist / ilip

ilip App test support

0 stars 0 forks source link

upstream to Google WebRTC codebase #40

Open bartuer opened 6 years ago

bartuer commented 6 years ago

those not implemented (31) haven't got implemented
they simply removed
- AudioDeviceObserver https://webrtc-review.googlesource.com/c/src/+/6300/3/modules/audio_device/ios/audio_device_not_implemented_ios.mm
- AGC (Automatically Gain Control) https://webrtc-review.googlesource.com/c/src/+/31520/8/modules/audio_device/ios/audio_device_not_implemented_ios.mm
all Volume control not implemented keep not implemented
get a list of commits missed from 1 year and 10 month ago from 41ed7e1715e91818cb70727f9169a24984b070ed to fb09eeb8f1b7e13d6b8a0a120af10bfd6ad576c8 about 40 commits
among those commit, only 5 ~ 6 is crash and session management related

bartuer commented 6 years ago

audio_device_ios.mm.log

bartuer commented 6 years ago

All speaker and microphone volume control is not implement https://chromium.googlesource.com/external/webrtc/+/master/modules/audio_device/ios/audio_device_not_implemented_ios.mm

bartuer commented 6 years ago

Let's focus on commits

fb09eeb8f1b7e13d6b8a0a120af10bfd6ad576c8 sample rate reset to avoid crash https://webrtc-review.googlesource.com/c/src/+/24864/7/modules/audio_device/ios/audio_device_ios.mm
32026c30785cf8b496ed574400341fa2e937f28a remove AudioDeviceIOS::SetLoudspeakerStatus https://webrtc-review.googlesource.com/c/src/+/23740/5/modules/audio_device/ios/audio_device_ios.mm
09a76193f5fa87bfacefd2ea15249338792aad1d thread checker and new audio stream prepare https://chromium-review.googlesource.com/c/external/webrtc/+/628716/5/webrtc/modules/audio_device/ios/audio_device_ios.mm

051d15156967bf5702b15789b62c98c97ef58577 add log for RTCSession https://chromium.googlesource.com/external/webrtc/+/051d15156967bf5702b15789b62c98c97ef58577%5E%21/#F0

17802ae258e4eecef0ae9825b7962c9bd179ea6c ensure same status on iOS and android https://chromium.googlesource.com/external/webrtc/+/17802ae258e4eecef0ae9825b7962c9bd179ea6c%5E%21/#F1

84cab205f51a42e23ed06a4fa6d8bf933b0f140a return 0 instead of Macro of https://chromium.googlesource.com/external/webrtc/+log/master/modules/audio_device/ios/audio_device_ios.mm

bartuer commented 6 years ago

Let's focus on Audio Session iOS implement: RTCAudioSession+Configuration.mm and RTCAudioSession.mm