search

hackjutsu / Lepton

💻 Democratizing Snippet Management (macOS/Win/Linux)
https://hackjutsu.com/Lepton
MIT License
10.16k stars 471 forks source link

[Feature Request] Store token in safe place like keychain #319

Open khanhicetea opened 6 years ago

khanhicetea commented 6 years ago

Hi, thanks for creating this awesome app !

Currently, Lepton save Github access token in User Data storage as plain text (macOS : ~/Library/Application\ Support/Lepton/storage/token.json)

Could we store sensitive data inside keychain of OS ?

I recommend using this lib : https://github.com/atom/node-keytar

hackjutsu commented 6 years ago

That's a good call! Would you mind sending a PR for that given you have done some research in this area?

khanhicetea commented 6 years ago

I'm a newbie JS developer. But I will try my best to make a PR for this feature :)

khanhicetea commented 6 years ago

I made a PR, please help me on review code (sorry for bad code b/c I'm new in JS and Electron) :)

Thank you very much !