search

hackjutsu / Lepton

💻 Democratizing Snippet Management (macOS/Win/Linux)
https://hackjutsu.com/Lepton
MIT License
10.14k stars 475 forks source link

Login by GitHub token #412

Closed DoneSpeak closed 3 years ago

DoneSpeak commented 4 years ago

I think it would be safer to allow the client to login with Github token instead of redirect to Github page to ask user to login with their GitHub account.

GabrielNicolasAvellaneda commented 4 years ago

@DoneSpeak @hackjutsu Is this the documentation related this new feature request? https://help.github.com/en/github/authenticating-to-github/creating-a-personal-access-token-for-the-command-line

Spreeuw commented 3 years ago

@hackjutsu I was looking at the code and it seems that internally the app is already using access tokens, is that correct? Would it be difficult to let the user choose between entering the access token or logging in? It would be quite useful because it would allow multiple people from a team access a single gist account without needing to share the login (which is against Github terms of service and can get you banned).

hackjutsu commented 3 years ago

https://github.com/hackjutsu/Lepton/commit/64b8d90c3be10b15b0d8bff0ba4fad65652808c1