search

hacklschorsch / Flos_LaTex_Template_fuer_Geisteswissenschaften

Latex Template für Abschluss- und andere Arbeiten in geisteswissenschaftlichen Fächern (DE, UTF8, Apa-Style Zitationen mittels BibLatex)
0 stars 1 forks source link

updates, to fix some issues of *non-best-practice* #3

Closed johannesbottcher closed 8 years ago

johannesbottcher commented 9 years ago

Fixed the mentioned issues and made other improvements to the code. I completely kicked out the font-settings and replaced them by libertine. A beginner might have major trouble to get the fonts. Feel free to reverse back or reject the pull request.

hacklschorsch commented 9 years ago

Hi Johannes. Thank you for your Pull Request!

I do have a few comments, though:

  1. Please do commit and push your code changes. I can only see a compiled PDF.
  2. Please separate your PR into different commits, at least: changes that will not affect formatting of the resulting document (like updating obsolete packages) and changes that do change the look of the document (like using another font). It will make it much easier for people to accept your changes. For example: I bought and read a book about typography when I compiled this template, deliberately choosing fonts for headlines and body text that fit together et cetera. So I have a hard time accepting your font replacement. But I of course welcome changes that will put the LaTeX interpreter out of compatibility mode or what it was called.

For the record: While I did read a book about typography, I didn't read a book about LaTex. And I don't plan to. I don't really mind mediocre latex code quality as long as the resulting document is lookin' good, since most of the time, it's fire and forget, right? #yolo! (While helping my GF formatting her thesis, we did find a bug in biblatex-apa though, reported it to the author, and to my great joy he fixed the bug quickly and swiftly. Long live open source!)

johannesbottcher commented 9 years ago

That is a very good point, i'll have a look at it again and try to split the changes into several smaller commits. Since i don't have the fonts, they will be missing in all of them though. But it is easy enough to restore it ;-)

I wasn't aware that i did really just PR a pdf.

Splitted PR coming in a few days.

Thanks Johannes

On 07/09/2015 09:59 PM, Florian Sesser wrote:

Hi Johannes. Thank you for your Pull Request!

I do have a few comments, though:

  1. Please do commit and push your code changes. I can only see a compiled PDF.
  2. Please separate your PR into different commits, at least: changes that will not affect formatting of the resulting document (like updating obsolete packages) and changes that do change the look of the document (like using another font). It will make it much easier for people to accept your changes. For example: I bought and read a book about typography when I compiled this template, deliberately choosing fonts for headlines and body text that fit together et cetera. So I have a hard time accepting your font replacement. But I of course welcome changes that will put the LaTeX interpreter out of compatibility mode or what it was called.

For the record: While I did read a book about typography, I didn't read a book about LaTex. And I don't plan to. I don't really mind mediocre latex code quality as long as the resulting document is lookin' good, since most of the time, it's fire and forget, right? #yolo! (While helping my GF formatting her thesis, we did find a bug in biblatex-apa though, reported it to the author, and to my great joy he fixed the bug quickly and swiftly. Long live open source!)

Reply to this email directly or view it on GitHub: https://github.com/hacklschorsch/Flos_LaTex_Template_fuer_Geisteswissenschaften/pull/3#issuecomment-120128074