search

hackmcgill / dashboard

🐥 McHacks dashboard
https://app.mchacks.ca
MIT License
30 stars 8 forks source link

Reformat boolean variables to a specific naming structure #844

Open loreina opened 4 years ago

loreina commented 4 years ago

Short discussion on boolean state variables, and if we should use loading or isLoading

Seems like we collectively prefer loading but code base uses is<BooleanVar> throughout and might be a React convention?

Could be nice to look into and if we should reformat them to something we like internally

Ref: https://github.com/hackmcgill/dashboard/pull/842#discussion_r456830889

image

pierreTklein commented 3 years ago

The benefit of is<bool name> is that the type of the variable is immediately understood. Definitely worth looking up some naming conventions from large TS projects and using that as inspiration for this project’s naming conventions.