Feat/868 resume component

jamesxu123 commented 3 years ago

Tickets:

HCK-#868

List of changes:

New resume component style

Type of change:

Please delete options that aren't relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How did you do this?

How to test:

Questions:

PR Checklist:

[x] Merged develop branch (before testing)
[x] Linted my code locally
[ ] Listed change(s) in the Changelog
[ ] Tested all links in project relevant browsers
[x] Tested all links on different screen sizes
[x] Referenced all useful info (issues, tasks, etc)

Screenshots:

close #868

jamesxu123 commented 3 years ago

Before any merges, I had a couple of questions:

Is the max file size 1MB? Not sure if the Figma was just for show.
Are we limited to PDFs only? I just kind of assumed so, but I can always change it.

logan-r commented 3 years ago

Let's stick with 4MB
Yeah, pdf only

jamesxu123 commented 3 years ago

I fixed the outline, it was a focus state thing.

About seeing the file, do you mean like a local link to open the file that they have selected? I don't think the resume is uploaded until the submit the form. I do have a small subtitle with the file name already, but I can add that button if needed.

jamesxu123 commented 3 years ago

Yeah personally I think having the file name should be good. I’m not sure if I’ve seen a file:// uri for file uploads elsewhere.

logan-r commented 3 years ago

Yeah did a bit of invistigating and it appears that we can't link to local file:// uri before uploading because that's a security flaw - we could encode the file using FileReader then use data:// uri to link to it but that's too much effort for a very minor feature

hackmcgill / dashboard