hackmcgill / dashboard

🐥 McHacks dashboard
https://app.mchacks.ca
MIT License
30 stars 9 forks source link

Feature: create stats dashboard page #962

Open chenxuan-zhou opened 2 years ago

chenxuan-zhou commented 2 years ago

Tickets:

Type of change:

Please delete options that aren't relevant.

How did you do this?

Created the Stats and StatsApplicationGraph components in features. Added a new "/admin/stats" route for the Stats component.

How to test:

Automatic test at PR.

Questions:

I did not push the changes done by linting since many code that I didn't touch were also changed and there were many errors. Do I need to worry about this?

I had an interface that I would like to share between Stats and StatsApplicationGraph. Is there a good way of doing so? (Currently I just copied the interface over)

PR Checklist:

Screenshots:

Search _ McHacks — Mozilla Firefox 11_29_2021 4_07_36 PM Search _ McHacks — Mozilla Firefox 11_29_2021 4_07_41 PM

pierreTklein commented 2 years ago

You can add & export an interface as a separate file and then import it into both files you want to use it. We do this for other interfaces too!

chenxuan-zhou commented 2 years ago

You can add & export an interface as a separate file and then import it into both files you want to use it. We do this for other interfaces too!

Thank you Theo! I put the interface in a separate file in the latest commit. Does the export style look correct?