Closed msohaill closed 7 months ago
Changes seem to break search filters for me (Search Hackers). For example, if I try to filter by school, I have to click the button more than once for the changes to be reflected. This does not appear to be the case previously.
Unfortunately, my back end doesn't seem to be set up completely?
Not sure about this but we can check it out together
Changes seem to break search filters for me (Search Hackers). For example, if I try to filter by school, I have to click the button more than once for the changes to be reflected. This does not appear to be the case previously.
Debugged and seems setState was used incorrectly somewhere and the synchronicity errors did not surface in React 16 but do in 18. Fixed it and I'll see if there's anywhere else something similar happens
List of changes:
Type of change:
Please delete options that aren't relevant.
How did you do this?
Basically just using
ncu -u
(npm-check-upgrade) to update all dependencies and then updating system Node version and then doing some testing/tinkering. Read up on the various package APIs for those that were broken.How to test:
Each working component needs to be tested to ensure no functionality has been broken. Unfortunately, my back end doesn't seem to be set up completely? Or perhaps it is just meant to be like that, so I am not able to test completely. But, I have test what I can and everything seems to be great!
Questions:
PR Checklist:
develop
branch (before testing)Screenshots: