Closed msohaill closed 3 months ago
Drive-by comment: thanks for cleaning up this repository. Do you still need a review on this? Happy to review it.
@pierreTklein For sure, that would be great! I think this just slipped through the cracks after the hackathon
List of changes:
new
and mongoose no longer accepting callbacks. We used to use thesequeryCallbackFactory
andupdateCallbackFactory
functions that actually ran every single query twice! I've migrated and fixed this behaviour so (technically) all queries should be twice as fast now 😂Type of change
Please delete options that are not relevant.
How has this been tested?
npm run test
is successful!Test Configuration:
Firmware version: Hardware: Toolchain: SDK:
Questions for code reviewers?
None come to mind.
Checklist: