UseCDN: true likely to break VPNs and tor

hackmdio / codimd

CodiMD - Realtime collaborative markdown notes on all platforms.

https://hackmd.io/c/codimd-documentation

GNU Affero General Public License v3.0

9.24k stars 1.05k forks source link

UseCDN: true likely to break VPNs and tor #1277

Open kpcyrd opened 5 years ago

kpcyrd commented 5 years ago

Somebody sent me a link to a pad hosted at https://hackmd.c3d2.de, I've tried to open it and got unstyled html:

broken

I thought ublock might've blocked something essential but the blocklist was empty. Opening the console I got SRI failures for cdnjs.cloudflare.com, which seemed odd. I've tried to open one of the links of a js file and got this:

banned

jackycute commented 5 years ago

There isn't much thing we can do to solve issue of ISP or TOR network. You can try to set useCDN: false and see if that works.

kpcyrd commented 5 years ago

A few ideas that could be explored:

Remove the UseCDN option and always self-host assets
Default UseCDN to false, so only instances that explicitly want cloudflare assets depend on cloudflare
Add a comment next to the setting to document that not setting it to false is going to cause issues for vpn and tor users