search

hackmdio / codimd

CodiMD - Realtime collaborative markdown notes on all platforms.
https://hackmd.io/c/codimd-documentation
GNU Affero General Public License v3.0
9.11k stars 1.05k forks source link

History page display is misaligned #1778

Closed u1ymd closed 1 year ago

u1ymd commented 1 year ago

After updating to v2.4.2, the history page is misaligned. This makes it impossible to press some buttons. This is occurring in Chrome and Safari.

image
slhck commented 1 year ago

Same here, this actually makes it impossible to use the app at all!

Adding this to the CSS provides a temporary fix:

#history .form-inline {
    margin-top: 20px;
}
u1ymd commented 1 year ago

"New note" button area still looks a little low, but the button can now be pressed. Thanks for your help.

image
slhck commented 1 year ago

Please leave this issue open. It's still a bug that needs to be fixed!

jackycute commented 1 year ago

PR is welcomed!

same as #1783

slhck commented 1 year ago

I've looked at the code a while ago and I couldn't find the part that is relevant for that. Otherwise I would've proposed a fix.

You have an open bug that affects the entire UI in a big way, initially said you were looking at it, then you are asking for PRs to fix it. I find this a bit strange.

While no open source maintainer is forced to provide support for their software, you are in the best position to fix this within probably minutes. So I hope this can be addressed soon.

jackycute commented 1 year ago

@slhck sorry for the confusion, I getting back this just now and found the issue is pretty small which shown as your above CSS. So I think it would be a good opportunity for the issue opener to open PR and earn some credits. I would love to fix this if no one responses.

slhck commented 1 year ago

Thanks. As I said, I checked the code but I couldn't find the relevant part to propose the fix. I'm fact the most recent release broke this, and I couldn't find the breaking commit (I checked all the diffs)...

jackycute commented 1 year ago

Maybe that's the browser version updates broke this, I will propose a fix.