hackmdio / codimd

CodiMD - Realtime collaborative markdown notes on all platforms.
https://hackmd.io/c/codimd-documentation
GNU Affero General Public License v3.0
9.24k stars 1.05k forks source link

Update minimum required node.js version to v12 with npm package dependencies #1799

Closed PeterDaveHello closed 1 year ago

PeterDaveHello commented 1 year ago

Looks like the node.js and npm dependencies didn't get update for a while, node.js v10 is EoL at 2021-04-30, and there could be a lot of security vulnerabilities since the last release, especially for those using pre-built Docker image on Docker Hub.

The idea here, is try to increase the baseline of the node.js and npm packages "a little bit", and ideally will update to node.js v18, because both of node.js v14 & v16 will reach EoL this year, node.js v12 is EoL at 2022-04-30 last year.

As I can't guarantee how much I can contribute, each PR won't be large, so that we can get it reviewed and merged in a more agile way ;)

Currently, npm run test is the assurance of the update not breaking things, please let me know if that's not enough. Thanks.

Reference:

PeterDaveHello commented 1 year ago

Looks like there are some thing need to be fixed. (Should also run npm run build)