hackmdio / codimd

CodiMD - Realtime collaborative markdown notes on all platforms.
https://hackmd.io/c/codimd-documentation
GNU Affero General Public License v3.0
9.11k stars 1.05k forks source link

Add the logout callback to prevent exception. #1813

Closed hcyuser closed 6 months ago

jackycute commented 11 months ago

Hi @hcyuser,

Thanks for contribution. Can you explain what is this PR solving?

hcyuser commented 11 months ago

If we didn't add a callback in req.logout(callback), It would get Error: req#logout requires a callback function on the webpage when running node app.js and clicking Sign out on the webpage.

jackycute commented 11 months ago

Thanks for adding this. This is caused by https://stackoverflow.com/questions/72336177/error-reqlogout-requires-a-callback-function from https://github.com/jaredhanson/passport/issues/902#issuecomment-1133897569

Yukaii commented 6 months ago

closed in favor of #1837