search

hackmdio / codimd

CodiMD - Realtime collaborative markdown notes on all platforms.
https://hackmd.io/c/codimd-documentation
GNU Affero General Public License v3.0
9.11k stars 1.05k forks source link

Fix the uploadimage form #1814

Closed hcyuser closed 6 months ago

jackycute commented 11 months ago

Hi @hcyuser,

Thanks for contribution. Can you explain what is this PR solving?

hcyuser commented 11 months ago

When I set up the image upload in local file system, I found I need to change path key into filepath to make it upload image successfully, which means the structure of files changed.

jackycute commented 11 months ago

Oops, sorry for clicking wrong button.

jackycute commented 11 months ago

@hcyuser Can you describe the error message like paste the error text or screenshot? I think this is caused by https://github.com/hackmdio/codimd/pull/1789 and was changed from https://github.com/node-formidable/formidable/pull/689

hcyuser commented 11 months ago

@hcyuser Can you describe the error message like paste the error text or screenshot?

I think this is caused by https://github.com/hackmdio/codimd/pull/1789 and was changed from https://github.com/node-formidable/formidable/pull/689

I got Image path is missing or wrong on the terminal. After that, I found the structure of files changed, and therefore I modified it.

Yukaii commented 6 months ago

closed in favor of #1836