search

hackmdio / codimd

CodiMD - Realtime collaborative markdown notes on all platforms.
https://hackmd.io/c/codimd-documentation
GNU Affero General Public License v3.0
9.32k stars 1.06k forks source link

Let guests choose their own name #268

Open dampfklon opened 7 years ago

dampfklon commented 7 years ago

As the title states let unregistered people choose their shown nickname, like its possible in etherpad-lite

jackycute commented 7 years ago

Hi @dampfklon, Currently we are NOT saving unregistered people (guest) authorship, so I think it might not needed be able to change guest name. BTW, hackpad also can't change guest name.

dampfklon commented 7 years ago

Hi its not about saving the authorship, the current cursor positions are currently shown in the editor with the generic guest names, those are not really usefull so I thought changing them to a meaningfull name would be nice

jackycute commented 7 years ago

Yeah, now we'll give a random name from a package called chance. So this sounds like a reasonable idea! But the name will only last for a session, maybe kind of costly to user?

dampfklon commented 7 years ago

I can only argue from our use case. We use hackmd to write protocols of online meetings while those take place many people simultaneously work on a document. In this case the generic names are bad because you can not see who writes. After the meeting is over the document no longer is edited. So a name only last a session would no problem.

jackycute commented 7 years ago

OK, let's do this.

ccoenen commented 7 years ago

This also extends to "let people in general choose their own name". Right now, I'm registered with an email address starting with mail@<something>. My Hackmd calls me mail - I haven't found a place to change it, yet.

jackycute commented 7 years ago

@ccoenen That's another issue #314

SISheogorath commented 7 years ago

Some hints:

https://github.com/hackmdio/hackmd/blob/ea9b1557f9834b2b140bd9b07488b5fca3953791/lib/realtime.js#L595-L623

Here we generate the username. Currently, there is no way to update it afterward. It's not a trivial issue, but can be done by someone who is familiar to JS.

dakira commented 6 years ago

This would be great. We have the exact same usecase as @dampfklon (+ the same problem with many users just called "mail" because that's how their email address begins).