hackmdio / vscode-hackmd

The official HackMD VScode extension!
https://marketplace.visualstudio.com/items?itemName=HackMD.vscode-hackmd
MIT License
132 stars 14 forks source link

Wrong email or password #32

Open junghoocho opened 3 years ago

junghoocho commented 3 years ago

I am using hackmd-vscode plugin v1.1.2 with vscode 1.49.1 on MacOS 10.15.6

After I install hackmd plugin and try to login, I get "Wrong email or password, please enter again" error message. I am able to login successfully on the hackmd.io website using the same email and password.

ctwdtw commented 3 years ago

I tested on plugin v1.1.2 with vs-code 1.49.3 on MacOS 10.15.7 It seems that the plugin does not support third-party auth such as Sign in Via Google yet. However, it works for accounts that sign up for the service using an email instead of third-party auth.

stefandesu commented 3 years ago

Having the same issue with a self-hosted CodiMD instance that uses LDAP for authentication. VSCode 1.53.0-exploration (ARM64), plugin version v1.1.2, macOS 11.0.1, M1 MacBook Air.

Edit: It's probably a separate issue. This extension uses the API's login method, but for LDAP authentication to work, it needs to use loginLdap. I'll try it out in a fork.

Edit 2: Got it working in a fork with this commit: https://github.com/stefandesu/vscode-hackmd/commit/b05186f7d6ff2ddc505fb1aac36e2a6e67835cbc Probably needs to be cleaned up for a PR. However, utility of this extension is greatly limited by not being able to edit and not having real-time collaboration.