Analog components - Githubissues

hackndev / zinc

The bare metal stack for rust

zinc.rs

Apache License 2.0

1k stars 100 forks source link

Analog components #117

Open thehydroimpulse opened 10 years ago

thehydroimpulse commented 10 years ago

I just got a hold on the lpc1768 and the MMA7361 accelerometer and I'm just curious on the story of analog inputs in Zinc. Ideally there would be ADC support within the API.

I'd definitely send a PR to add more robust support if that's the need for it.

Thoughts?

errordeveloper commented 10 years ago

I believe we need to wait for #108 to land, before adding any new I/O functionality. Am I correct, @farcaller?

farcaller commented 10 years ago

No, we don't really need to wait on new ioregs, as the refactoring work would be quite big anyways, one or two more regs don't matter.

I must say that I've never used the ADC in lpc1768, so I don't have any suggestion on where to start, but I would gladly review any PR that implements it.

A few points:

the ADC driver should be based around "universal" API trait defined in hal (hal/adc.rs)
it must be based on PT
MMA7361 driver is also fine, it will land in drivers.

thehydroimpulse commented 10 years ago

@farcaller Ok, awesome! I started on the mma driver and then I'll move my way refactoring it into an ADC trait and implementation for the specific board.