Fix nightly fallout

[0xc0170]

In progress, currently in green state for k20, all the other platforms need to be done and also will need to run tests + some hw tests

Summary of this PR (or what has changed in rustc):

• Option and Result in Core clean up - means the code should use properly namespaces for those 2
• Copy is opt-in, enums and structs by default are non copyable

And one error which we should carefully review, is the one operate on borrowed type error, was no able to track why it suddenly failed.

[0xc0170]

I overstated above, k20 app are green , not tests :-) More to come

btw, unknow label means?

[0xc0170]

@bgamari Why zeroed was implemented with Copy() ? Please review, thanks

This fixes errors, there is dozen of warnings, due to copy opt-in. we can fix those after this one goes in.

[bgamari]

@0xc0170 sorry for the latency. I was away from keyboard for most of the weekend and have been struggling to build a working rust toolchain. Looking at it again now.

[bgamari]

@0xc0170 I'm not sure I understand your question concerning zeroed. Could you clarify?

[bgamari]

Ahh, do you mean zeroed_safe in ioreg::test? mem::zeroed requires Copy as you can only use it to construct plain old data. Things that aren't Copy will likely have additional invariants that render zeroed unsafe. At least this is my inference.

[bgamari]

@0xc0170 you'll likely want to pull this on to your branch.

[bgamari]

The correct solution here is likely to add Copy impls for the types generated by ioregs!. I've started doing this on my fork of your branch. Unfortunately debugging macros is terrible.

[0xc0170]

Yes, that was the error indicated, implement Copy for ioregs! .

Share with us the progress, I have checked your branch , seems you are on track.

[bgamari]

I think I finally have ioregs! working again. I'll be opening a new version of this pull request shortly.

[0xc0170]

Awesome!

[bgamari]

Closing in favor of #260.