search

hackndev / zinc

The bare metal stack for rust
zinc.rs
Apache License 2.0
1k stars 100 forks source link

Minimize use of DUMMY_SP #298

Closed mcoffin closed 9 years ago

mcoffin commented 9 years ago

Makes more meaningful feedback from macro builders.

Fixes (for ioreg, not for platformtree) #99

farcaller commented 9 years ago

We should have a lint warning for DUMMY_SP and unwrap() really.

mcoffin commented 9 years ago

While DUMMY_SP is pretty specific to compiler plugins (and I suspect it might be removed). I'll probably whip up an external lint plugin to check for unwrap().

mcoffin commented 9 years ago

@farcaller FYI https://github.com/mcoffin/syntaxext_lint

Before this gets merged, I'll publish the dependency crate to crates.io and we can avoid depending on my version from github.

farcaller commented 9 years ago

:clap:

mcoffin commented 9 years ago

Slightly changing the scope of this PR to only minimize DUMMY_SP for ioreg since platformtree might be coming up on a rework.

No longer completely fixes #99, but it goes a long way towards doing so.

hacknbot commented 9 years ago

Can one of the admins verify this patch?

farcaller commented 9 years ago

ok to test

mcoffin commented 9 years ago

I can't see what went wrong with the jenkins build as it's behind a login screen. Probably just doesn't have the build script from the other branch?

farcaller commented 9 years ago

Exactly, didn’t have enough time to squash and merge, will do that in an hour is so. Then it just needs to be rebased.

farcaller commented 9 years ago

Okay, this can be rebased on master now.

mcoffin commented 9 years ago

Just got around to rebasing this as I'm pretty busy with finals through the end of the week. Opened #313 because of issues with the jenkins script.

farcaller commented 9 years ago

retest this please

farcaller commented 9 years ago

:+1: