Cargo feature refactoring

hackndev / zinc

The bare metal stack for rust

zinc.rs

Apache License 2.0

1k stars 100 forks source link

Cargo feature refactoring #307

Closed mcoffin closed 9 years ago

mcoffin commented 9 years ago

As exposed in #306, there's still a need for cargo features that aren't MCU features, and build.rs needs a way to tell them apart.

Prefixed all the MCU features with mcu_
Converted the old cfg_multitasking config flag to a cargo feature (multitasking)

posborne commented 9 years ago

LGTM. Maybe squash to a single commit.

mcoffin commented 9 years ago

@posborne Squashed down to two since it's really two separate operations.

posborne commented 9 years ago

:+1:

hacknbot commented 9 years ago

Can one of the admins verify this patch?

bharrisau commented 9 years ago

LGTM

mcoffin commented 9 years ago

@bharrisau Looked like hacknbot was working again for second, guess not. Any chance we'll get it back?

bharrisau commented 9 years ago

Not sure. I forgot it was there TBH. On 4 Jun 2015 8:43 am, "Matt Coffin" notifications@github.com wrote:

@bharrisau https://github.com/bharrisau Looked like hacknbot was working again for second, guess not. Any chance we'll get it back?

— Reply to this email directly or view it on GitHub https://github.com/hackndev/zinc/pull/307#issuecomment-108658925.