Closed richo closed 8 years ago
This gets zing building cleanly.
I will hopefully have a look at the tests tomorrow.
Looks nice, thanks for your work. I'll keep this open until we get green on travis though.
Works for me! There's some pretty severe breakage in the way that ASTs are constructed, and my lack of familiarity with the code is making debugging hard.
If it's ok with you I'll braindump into this issue and see if anything makes more sense to you?
Sounds good.
As an aside, we've been using homu (http://homu.io/) on nix and it has worked out pretty well. https://github.com/nix-rust/nix/blob/master/CONTRIBUTING.md#homu-the-bot-who-merges-all-the-prs. Homu will verify that the resultant merged state passes before merging into master.
Cool, thanks, I'll take a look at it (it's the next iteration of bors, right?)
Yes, I'm not sure if it is the next generation or just the generally available version. Either way, yes -- it's basically bors.
This fixes ioreg
, but it seems platformtree
still uses some of the old types (for instance platformtree/src/parser.rs:19
imports syntax::ast::LitInt
).
Thanks to @Gyscos I was able to build blinky_lpc17xx using rust 1.9-dev.
I'm curious to see what travis will make of the tests, but this is progressing.
already merged
Yep. Closing this.
I've started trying to get Zinc working on modern rust.
I'm currently blocked on https://github.com/rust-lang/rust/pull/32269 but this at least massively cuts down on the compile errors.