hackoregon / backend-examplar-2018

an example dockerized geo-aware django backend
MIT License
4 stars 5 forks source link

Removes redundant wait-for-it helper #71

Closed MikeTheCanuck closed 6 years ago

MikeTheCanuck commented 6 years ago

I believe this is unnecessary in CI context, since tests will still fail if the database is unavailable, and since the database is very unlikely to fail transiently. None of the 2017 database instances have even once rebooted in a year (as measured by the fact their non-permanent, non-EIP IP addresses have ever changed). No evidence that they have ever gone unavailable for short or long periods either.

znmeb commented 6 years ago

Right - we only need to wait in the development environment. And if you remove the wait script, one of the packages is also unnecessary - the one that carries psql ;-).