hackoregon / civic-devops

Master collection point for issues, procedures, and code to manage the HackOregon Civic platform
MIT License
11 stars 4 forks source link

Create/implement task definition for 2018 Disaster-Resilience-Service project #103

Closed iant01 closed 6 years ago

iant01 commented 6 years ago

Create the service sub directory and service.yaml file for use in getting the service task definition into ECS.

MikeTheCanuck commented 6 years ago

Environment variables expected by the container to be passed in from ECS at runtime:

znmeb commented 6 years ago

POSTGRES_NAME is the database name, right??

nam20485 commented 6 years ago

@znmeb Correct, POSTGRES_NAME is the postgres DB name. E.g. for my disaster.backup you gave me, it is disaster.

nam20485 commented 6 years ago

@MikeTheCanuck Your list is close, just need to add:

DEBUG=False

(Taken from: https://github.com/hackoregon/disaster-resilience-backend/blob/development/production-docker-compose.yml)

MikeTheCanuck commented 6 years ago

If the variable is only needed in a docker-compose file, then we don't need to read it into the container.

It looks like the variable is declared and used in settings.py, and if we never injected a different value, the default of TRUE will still work.

It might not be the intended effect for production, in which case it's worth considering whether to set line 26 = FALSE instead, and override it with the .env file that the developer has to use anyway.

BrianHGrant commented 6 years ago

Yeah, let's set the default in setting.py to FALSE

iant01 commented 6 years ago

This issue was for creating the task definition for the service, don't know were Mike intended the above information to go but this is not the correct issue.

Once the above information finds an issue home and PR 20 is merged this issue can be closed

MikeTheCanuck commented 6 years ago

PROJECT_NAME="backend"