Open MikeTheCanuck opened 5 years ago
As Michael rightly points out, it would be good to refactor out the duplicative Task Role definition in each of the Fargate service templates into a single common nested template that can be consumed by all Fargate services: https://github.com/hackoregon/hackoregon-aws-infrastructure/pull/69#discussion_r298851952
Examples here: https://github.com/hackoregon/hackoregon-aws-infrastructure/pull/69/files/13a95b89985366ea2397e47a5661d2d6e85883b8#diff-1b3adc1afead09b44609a4036f7f4c7dR203 https://github.com/hackoregon/hackoregon-aws-infrastructure/pull/69/files/13a95b89985366ea2397e47a5661d2d6e85883b8#diff-4fa1203b0e413fc8dd061ccff4e51668R203
As Michael rightly points out, it would be good to refactor out the duplicative Task Role definition in each of the Fargate service templates into a single common nested template that can be consumed by all Fargate services: https://github.com/hackoregon/hackoregon-aws-infrastructure/pull/69#discussion_r298851952
Examples here: https://github.com/hackoregon/hackoregon-aws-infrastructure/pull/69/files/13a95b89985366ea2397e47a5661d2d6e85883b8#diff-1b3adc1afead09b44609a4036f7f4c7dR203 https://github.com/hackoregon/hackoregon-aws-infrastructure/pull/69/files/13a95b89985366ea2397e47a5661d2d6e85883b8#diff-4fa1203b0e413fc8dd061ccff4e51668R203