Closed jaronheard closed 4 years ago
Per discussion with @DingoEatingFuzz, making the following adjustments:
ui-labs
, in favor of developing within project packages and marking components experimentalui-platform
in favor of developing within project packageui-cards
and ui-core
? Could they bundled?I can't provide the caliber of technical review that @DingoEatingFuzz can, so I'll focus on participatory design aspects. These are probably the kinds of things that I'd put in an RFC about the migration process:
@Dianna, thanks for the review! In response to your bullets:
Should we transition all apps using the existing component library to this modular version and completely remove the old library?
See #1207 for details on your first bullet, and let me know if you have further comments after reviewing that.
I'm a bit concerned about the READMEs (sic)
Agreed, I'll flesh out the READMEs per your suggestion. I did the minimum viable READMEs as part of my first PR with the expectation that I'd fill them out a bit once we knew how everything was shaking out, so thanks for the reminder.
- There are some duplicated files across packages. Are those intentional or by accident?
The duplicated files that you identified was accidental. I've removed the extraneous asset folder that existed in ui-charts
- What's the deal with the .toMove files? Is that part of a multistep rollout or something?
Yep, rather than update 2018 to use the new components now, I'm going to do that in a separate PR. The components that will live within 2018 are in a temporary .toMove
folder, and will live within src
in the future.
The tarball size comparison[1]:
Ok, I think this is ready now -- the comments have either been resolved, or incorporated into #1207.
Summary
This pull request breaks up the
component-library
into smaller packages, with the intention of replacing and deprecating the component library in favor of these smaller modules.It leaves the current component-library architecture as the default for now, so all components are now duplicated across packages. The plan for moving to the new components will be detailed in an upcoming RFC.
New packages
Next steps
Future work